[argtable3] Update to v3.2.1 #18325
Merged
[argtable3] Update to v3.2.1 #18325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have modified CMake scripts in Argtable3, which now supports the vcpkg manifest mechanism, we also remove unnecessary code snippets and deprecated targets.
|
|
PhoebeHui
added
the
category:port-update
PhoebeHui
requested changes
Jun 9, 2021
PhoebeHui
approved these changes
Jun 9, 2021
|
Great, this is awesome! Thanks @tomghuang :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have modified Argtable3 CMake scripts, which now respect
BUILD_SHARED_LIBSand build either the static library or the dynamic library at a time, so the latest Argtable3 can support vcpkg manifest without any issue. In the patch, we not only update the port to the latest stable release, but also remove unnecessary code snippets and deprecated targets/variables.Describe the pull request
What does your PR fix?
Fixes [argtable3] spurious build failure #12297. However, this patch is not only used to resolve old issues, but also used to point to the latest stable release.
Which triplets are supported/not supported? Have you updated the CI baseline?
All triplets should be supported. No, we didn't modify
ci.baseline.txt.Does your PR follow the maintainer guide?
Yes, we have followed the maintainer guide.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes, we have run the command to update the version information. You can see
baseline.jsonandargtable3.jsonin the patch.